SHS-5880: Changing <h3> tags in grouping titles to <h2> #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tle heading level
|
@ahughes3 Ready for you to review. |
ahughes3
approved these changes
Oct 23, 2024
joegl
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
h2instead ofh3as the default heading level for the grouping title (it's more common to needh2in HSDP sites)Need Review By (Date)
10/23
Urgency
medium
Steps to Test
Log in into the Tugboat Colorful site (you can use any other site that has a view with grouped results, the fix is independent of the theme)
Visit the Publications default views page. Scroll down to the "Link URL or Doc Publication List" view.
Confirm that the grouping titles (the years) are being displayed using a
<h2>titleEdit the view. In the "Fields" section, click on the "Content: Publication Year [hidden]" item. Search for the "Rewrite Results" section, check the "Override the output of this field with custom text" option and add the following text:
Click on "Apply (This display)" at the bottom of the dialog and then save the view.
Visit the Publications default views page again and confirm that the grouping title is now an
<h3>.PR Checklist